[Asterisk-code-review] app.h: Restore C++ compatibility for macro AST_DECLARE_APP_ARGS (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15441 )

Change subject: app.h: Restore C++ compatibility for macro AST_DECLARE_APP_ARGS
......................................................................


Patch Set 3:

> Patch Set 3:
> 
> > Oh, and ./configure executed with --enable-dev-mode and DONT_OPTIMIZE set in menuselect.
> 
> Reproducing thank you.
>  
> I think "we've" (I broke it so I'll fix it) got two choices here:
> 
> 1.  Figure out a way to revert this (revert) patch, and somehow get C++ usability without changing the "API" for AST_DEFINE_APP_ARGS*.
> 
> 2.  Convert all uses with static indexes into argv to use the named variables instead.
> 
> Which would you prefer?  I'll create a separate review for it.

I'd revert for now, as we'd like to do release candidates shortly, and then a discussion can be had for fixing properly. I'd defer to Kevin as he's been down this road already.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15441
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I5b9f02a9b290675682a1d13f1788fdda597c9fca
Gerrit-Change-Number: 15441
Gerrit-PatchSet: 3
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 24 Feb 2021 14:52:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210224/8b9bf958/attachment.html>