<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 3:</p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Oh, and ./configure executed with --enable-dev-mode and DONT_OPTIMIZE set in menuselect.</p></blockquote><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Reproducing thank you.<br> <br>I think "we've" (I broke it so I'll fix it) got two choices here:</pre><p style="white-space: pre-wrap; word-wrap: break-word;">1.  Figure out a way to revert this (revert) patch, and somehow get C++ usability without changing the "API" for AST_DEFINE_APP_ARGS*.</p><p style="white-space: pre-wrap; word-wrap: break-word;">2.  Convert all uses with static indexes into argv to use the named variables instead.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Which would you prefer?  I'll create a separate review for it.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">I'd revert for now, as we'd like to do release candidates shortly, and then a discussion can be had for fixing properly. I'd defer to Kevin as he's been down this road already.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15441">View Change</a></p><ul style="list-style: none; padding: 0;"></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/15441">change 15441</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/15441"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5b9f02a9b290675682a1d13f1788fdda597c9fca </div>
<div style="display:none"> Gerrit-Change-Number: 15441 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Jaco Kroon <jaco@uls.co.za> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 24 Feb 2021 14:52:11 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>