[Asterisk-code-review] local: Add test for dialing with a removed/declined audio stream. (testsuite[18])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/15836 )

Change subject: local: Add test for dialing with a removed/declined audio stream.
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/c/testsuite/+/15836/1/tests/channels/local/local_removed_audio_stream_request/sipp/bob.xml 
File tests/channels/local/local_removed_audio_stream_request/sipp/bob.xml:

https://gerrit.asterisk.org/c/testsuite/+/15836/1/tests/channels/local/local_removed_audio_stream_request/sipp/bob.xml@6 
PS1, Line 6:   <recv request="INVITE" crlf="true" />
Use a regex to confirm that the SDP does not contain the declined stream.


https://gerrit.asterisk.org/c/testsuite/+/15836/1/tests/channels/local/local_removed_audio_stream_request/test-config.yaml 
File tests/channels/local/local_removed_audio_stream_request/test-config.yaml:

https://gerrit.asterisk.org/c/testsuite/+/15836/1/tests/channels/local/local_removed_audio_stream_request/test-config.yaml@31 
PS1, Line 31:         # First iteration
This comment can probably be removed.


https://gerrit.asterisk.org/c/testsuite/+/15836/1/tests/channels/local/local_removed_audio_stream_request/test-config.yaml@36 
PS1, Line 36:                     'ordered-args': ['-timeout_error', '-key', 'custom_media_port', '6004'] }
Are these ordered-args strictly needed for the test? For instance, there appears to be no port checking.


https://gerrit.asterisk.org/c/testsuite/+/15836/1/tests/channels/local/local_removed_audio_stream_request/test-config.yaml@39 
PS1, Line 39:                     'ordered-args': ['-timeout_error', '-key', 'custom_media_port', '6004'] }
Same question. Can you just remove these ordered-args?



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/15836
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 18
Gerrit-Change-Id: If55c6ef39c322cb45f59e93bd4ef545957cf5c26
Gerrit-Change-Number: 15836
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 29 Apr 2021 21:56:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210429/6b210daa/attachment-0001.html>