<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/testsuite/+/15836">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/testsuite/+/15836/1/tests/channels/local/local_removed_audio_stream_request/sipp/bob.xml">File tests/channels/local/local_removed_audio_stream_request/sipp/bob.xml:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/15836/1/tests/channels/local/local_removed_audio_stream_request/sipp/bob.xml@6">Patch Set #1, Line 6:</a> <code style="font-family:monospace,monospace">  <recv request="INVITE" crlf="true" /></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Use a regex to confirm that the SDP does not contain the declined stream.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/testsuite/+/15836/1/tests/channels/local/local_removed_audio_stream_request/test-config.yaml">File tests/channels/local/local_removed_audio_stream_request/test-config.yaml:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/15836/1/tests/channels/local/local_removed_audio_stream_request/test-config.yaml@31">Patch Set #1, Line 31:</a> <code style="font-family:monospace,monospace">        # First iteration</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This comment can probably be removed.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/15836/1/tests/channels/local/local_removed_audio_stream_request/test-config.yaml@36">Patch Set #1, Line 36:</a> <code style="font-family:monospace,monospace">                    'ordered-args': ['-timeout_error', '-key', 'custom_media_port', '6004'] }</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Are these ordered-args strictly needed for the test? For instance, there appears to be no port checking.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/15836/1/tests/channels/local/local_removed_audio_stream_request/test-config.yaml@39">Patch Set #1, Line 39:</a> <code style="font-family:monospace,monospace">                    'ordered-args': ['-timeout_error', '-key', 'custom_media_port', '6004'] }</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Same question. Can you just remove these ordered-args?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/testsuite/+/15836">change 15836</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/testsuite/+/15836"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: 18 </div>
<div style="display:none"> Gerrit-Change-Id: If55c6ef39c322cb45f59e93bd4ef545957cf5c26 </div>
<div style="display:none"> Gerrit-Change-Number: 15836 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 29 Apr 2021 21:56:29 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>