[Asterisk-code-review] res_pjsip_dialog_info_body_generator: Include LOCAL/REMOTE tags in BL... (asterisk[16])

[Joe]

Joe has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15763 )

Change subject: res_pjsip_dialog_info_body_generator: Include LOCAL/REMOTE tags in BLF NOTIFY XML
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/15763/5/res/res_pjsip_dialog_info_body_generator.c 
File res/res_pjsip_dialog_info_body_generator.c:

https://gerrit.asterisk.org/c/asterisk/+/15763/5/res/res_pjsip_dialog_info_body_generator.c@205 
PS5, Line 205: 			snprintf(remote_target, sizeof(remote_target), "sip:%s@%s", connected_num,
In a previous version there was a variable set to the length of the connected_num, and either invalid or from_domain, plus "sip@:".  This was removed because the implementation there was not helpful, and actually could cause a buffer overflow.

The change here prevents the overflow, but will still present a truncated form of the invalid data.  Perhaps we should add a check, using the previous formula that if need > [PJSIP_MAX_URL_SIZE] then break out.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15763
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I20c5cf5b45f34d7179df6573c5abf863eb72964b
Gerrit-Change-Number: 15763
Gerrit-PatchSet: 5
Gerrit-Owner: Joe <ynadiv at corpit.xyz>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Comment-Date: Wed, 14 Apr 2021 19:20:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210414/4795acae/attachment.html>