<p><a href="https://gerrit.asterisk.org/c/asterisk/+/15763">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15763/5/res/res_pjsip_dialog_info_body_generator.c">File res/res_pjsip_dialog_info_body_generator.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/15763/5/res/res_pjsip_dialog_info_body_generator.c@205">Patch Set #5, Line 205:</a> <code style="font-family:monospace,monospace">                   snprintf(remote_target, sizeof(remote_target), "sip:%s@%s", connected_num,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">In a previous version there was a variable set to the length of the connected_num, and either invalid or from_domain, plus "sip@:".  This was removed because the implementation there was not helpful, and actually could cause a buffer overflow.</p><p style="white-space: pre-wrap; word-wrap: break-word;">The change here prevents the overflow, but will still present a truncated form of the invalid data.  Perhaps we should add a check, using the previous formula that if need > [PJSIP_MAX_URL_SIZE] then break out.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/15763">change 15763</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/15763"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I20c5cf5b45f34d7179df6573c5abf863eb72964b </div>
<div style="display:none"> Gerrit-Change-Number: 15763 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Joe <ynadiv@corpit.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-CC: Stanislav Abramenkov <stas.abramenkov@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 14 Apr 2021 19:20:46 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>