[Asterisk-code-review] Mofified funcs/func_curl.c so that we can set what constitutes a fai... (asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15066 )

Change subject: Mofified funcs/func_curl.c so that we can set what constitutes a  failure for curl requests for instance a 404 or 503. This is for ASTERISK-28825
......................................................................


Patch Set 2: -Code-Review

> Patch Set 2:
> 
> @joshua I spoke with the developer and supporting multiple error codes will require a lot more work which may make the code messy. Are you OK with it as is (it only allows you to specify one kind of error code).

>From a functionality in Asterisk perspective, I don't think supporting a single response code is acceptable. Once merged and released and people see the functionality, I can certainly see people raising questions about why only one and filing an issue that they tried multiple and it didn't work, or they need to support multiple.

I'll let others chime in on their own opinion.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15066
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I94443e508343e0a3e535e51ea6e0562767639987
Gerrit-Change-Number: 15066
Gerrit-PatchSet: 2
Gerrit-Owner: Dovid Bender <dovid at telecurve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 28 Oct 2020 09:39:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20201028/550e7fe4/attachment.html>