<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 2:</p><p style="white-space: pre-wrap; word-wrap: break-word;">@joshua I spoke with the developer and supporting multiple error codes will require a lot more work which may make the code messy. Are you OK with it as is (it only allows you to specify one kind of error code).</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">From a functionality in Asterisk perspective, I don't think supporting a single response code is acceptable. Once merged and released and people see the functionality, I can certainly see people raising questions about why only one and filing an issue that they tried multiple and it didn't work, or they need to support multiple.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I'll let others chime in on their own opinion.</p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ddd; color: #000000;">-Code-Review</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/15066">View Change</a></p><ul style="list-style: none; padding: 0;"></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/15066">change 15066</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/15066"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I94443e508343e0a3e535e51ea6e0562767639987 </div>
<div style="display:none"> Gerrit-Change-Number: 15066 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Dovid Bender <dovid@telecurve.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 28 Oct 2020 09:39:24 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>