[Asterisk-code-review] CI: Add PQ Stress jenkinsfile and update to get conf from environment (asterisk[17])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13772 )

Change subject: CI: Add PQ Stress jenkinsfile and update to get conf from environment
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

-1 so won't be missed. Overall though, is there any way to make this stuff more generic? So other tests found under the "custom" directory could be set and run vs. specifically named pq stress test?

https://gerrit.asterisk.org/c/asterisk/+/13772/1/tests/CI/pq.jenkinsfile 
File tests/CI/pq.jenkinsfile:

https://gerrit.asterisk.org/c/asterisk/+/13772/1/tests/CI/pq.jenkinsfile@73 
PS1, Line 73: configFileProvider([configFile(fileId: env.PQ_GATE_TESTS_CONFIG, variable: 'PQ_TESTS')]) {
Any way to make this more generic too?


https://gerrit.asterisk.org/c/asterisk/+/13772/1/tests/CI/pq_stress.jenkinsfile 
File tests/CI/pq_stress.jenkinsfile:

https://gerrit.asterisk.org/c/asterisk/+/13772/1/tests/CI/pq_stress.jenkinsfile@72 
PS1, Line 72: 					def stressTests
            : 					configFileProvider([configFile(fileId: env.PQ_STRESS_TESTS_CONFIG, variable: 'PQ_STRESS_TESTS')]) {
            : 					echo "Retrieved config file from ${env.PQ_STRESS_TEST}"
            : 						stressTests = readJSON file: env.PQ_STRESS_TESTS
            : 					}
            : 
            : 					for (def stressTest in stressTests) {
            : 
            : 						def testGroups
            : 						configFileProvider([configFile(fileId: stressTest, variable: 'PQ_STRESS_TEST')]) {
            : 						echo "Retrieved config file from ${env.PQ_STRESS_TEST}"
            : 							 testGroups = readJSON file: env.PQ_STRESS_TEST
            : 						}
            : 
Could this be made more generic, like CUSTOM_TESTS or something? Then other custom jobs could set it to run their "custom" tests.


https://gerrit.asterisk.org/c/asterisk/+/13772/1/tests/CI/pq_stress.jenkinsfile@98 
PS1, Line 98: 							def privateTestsuiteUrl = "http://gerrit.digium.internal/r/private-testsuite-tests"
Is there any way to have this passed in, so different urls could be used?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13772
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 17
Gerrit-Change-Id: I54a80ad59b80f5e1e10e291cc2ae0b2c2a5b30d4
Gerrit-Change-Number: 13772
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Fri, 07 Feb 2020 17:43:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200207/654388f1/attachment.html>