<p style="white-space: pre-wrap; word-wrap: break-word;">-1 so won't be missed. Overall though, is there any way to make this stuff more generic? So other tests found under the "custom" directory could be set and run vs. specifically named pq stress test?</p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13772">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13772/1/tests/CI/pq.jenkinsfile">File tests/CI/pq.jenkinsfile:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13772/1/tests/CI/pq.jenkinsfile@73">Patch Set #1, Line 73:</a> <code style="font-family:monospace,monospace">configFileProvider([configFile(fileId: env.PQ_GATE_TESTS_CONFIG, variable: 'PQ_TESTS')]) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Any way to make this more generic too?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13772/1/tests/CI/pq_stress.jenkinsfile">File tests/CI/pq_stress.jenkinsfile:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13772/1/tests/CI/pq_stress.jenkinsfile@72">Patch Set #1, Line 72:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> def stressTests<br> configFileProvider([configFile(fileId: env.PQ_STRESS_TESTS_CONFIG, variable: 'PQ_STRESS_TESTS')]) {<br> echo "Retrieved config file from ${env.PQ_STRESS_TEST}"<br> stressTests = readJSON file: env.PQ_STRESS_TESTS<br> }<br><br> for (def stressTest in stressTests) {<br><br> def testGroups<br> configFileProvider([configFile(fileId: stressTest, variable: 'PQ_STRESS_TEST')]) {<br> echo "Retrieved config file from ${env.PQ_STRESS_TEST}"<br> testGroups = readJSON file: env.PQ_STRESS_TEST<br> }<br><br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Could this be made more generic, like CUSTOM_TESTS or something? Then other custom jobs could set it to run their "custom" tests.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13772/1/tests/CI/pq_stress.jenkinsfile@98">Patch Set #1, Line 98:</a> <code style="font-family:monospace,monospace"> def privateTestsuiteUrl = "http://gerrit.digium.internal/r/private-testsuite-tests"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Is there any way to have this passed in, so different urls could be used?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13772">change 13772</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13772"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 17 </div>
<div style="display:none"> Gerrit-Change-Id: I54a80ad59b80f5e1e10e291cc2ae0b2c2a5b30d4 </div>
<div style="display:none"> Gerrit-Change-Number: 13772 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 07 Feb 2020 17:43:35 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>