[Asterisk-code-review] chan_oss: Remove libs of (12 year old) Video Console. (asterisk[13])

Alexander Traud asteriskteam at digium.com
Thu Apr 16 03:36:28 CDT 2020


Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14217 )

Change subject: chan_oss: Remove libs of (12 year old) Video Console.
......................................................................


Patch Set 1:

Not sure what ‘push out further’ means, do you mean it hides that dead code even further? The whole module is deprecated anyway and is going soon. If you like, I rip out the Video Console part completely now. However, the actual problem is the script ./configure: People see that some dependency is not fulfilled. Or they think Asterisk is capable of converting video but how … actually the Debian package for Asterisk 13 included (required) those four dependencies. Even a package maintainer got confused. Go figure!

I would like to remove those five checks in the script ./configure to avoid any confusion. Furthermore, this speeds up the script a bit. And when one day chan_oss is removed, the script configure does not need much change. Triple benefit without any drawback.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14217
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I2c64c85ad07bb8bfb97aa5a9876f9e818955210c
Gerrit-Change-Number: 14217
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Thu, 16 Apr 2020 08:36:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200416/13ee7a20/attachment.html>


More information about the asterisk-code-review mailing list