[Asterisk-code-review] queue_log: Add alembic script for generate db table for queue_log (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/4012 )

Change subject: queue_log: Add alembic script for generate db table for queue_log
......................................................................


Patch Set 2:

(1 comment)

-1 mostly for suggestion visibility.

https://gerrit.asterisk.org/c/asterisk/+/4012/2/contrib/ast-db-manage/queue_log/versions/4105ee839f58_create_queue_log_table.py 
File contrib/ast-db-manage/queue_log/versions/4105ee839f58_create_queue_log_table.py:

https://gerrit.asterisk.org/c/asterisk/+/4012/2/contrib/ast-db-manage/queue_log/versions/4105ee839f58_create_queue_log_table.py@21 
PS2, Line 21:         'queue_log',
I'm not really a database guy, but I believe it is usually considered a good practice to have at least one column marked as unique. As with most things there's always some debate about using an auto-increment field, but I think here it would suffice.

So I'd suggest adding an 'id' column marked auto-increment, and unique.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/4012
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I35b928a6251f9da9a1742b2cd14c63a00c3d0f0c
Gerrit-Change-Number: 4012
Gerrit-PatchSet: 2
Gerrit-Owner: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Name of user not set #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Rodrigo Ramirez Norambuena <a at rodrigoramirez.com>
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 18 Nov 2019 19:14:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191118/b4d141d3/attachment-0001.html>