<p style="white-space: pre-wrap; word-wrap: break-word;">-1 mostly for suggestion visibility.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/4012">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/4012/2/contrib/ast-db-manage/queue_log/versions/4105ee839f58_create_queue_log_table.py">File contrib/ast-db-manage/queue_log/versions/4105ee839f58_create_queue_log_table.py:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/4012/2/contrib/ast-db-manage/queue_log/versions/4105ee839f58_create_queue_log_table.py@21">Patch Set #2, Line 21:</a> <code style="font-family:monospace,monospace">        'queue_log',</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'm not really a database guy, but I believe it is usually considered a good practice to have at least one column marked as unique. As with most things there's always some debate about using an auto-increment field, but I think here it would suffice.</p><p style="white-space: pre-wrap; word-wrap: break-word;">So I'd suggest adding an 'id' column marked auto-increment, and unique.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/4012">change 4012</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/4012"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I35b928a6251f9da9a1742b2cd14c63a00c3d0f0c </div>
<div style="display:none"> Gerrit-Change-Number: 4012 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Rodrigo Ramirez Norambuena <a@rodrigoramirez.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Mark Michelson <mmichelson@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Name of user not set #1000019 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Rodrigo Ramirez Norambuena <a@rodrigoramirez.com> </div>
<div style="display:none"> Gerrit-CC: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 18 Nov 2019 19:14:13 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>