[Asterisk-code-review] app voicemail: Remove need to subscribe to stasis (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10132 )

Change subject: app_voicemail: Remove need to subscribe to stasis
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/10132/2/apps/app_voicemail.c
File apps/app_voicemail.c:

https://gerrit.asterisk.org/#/c/10132/2/apps/app_voicemail.c@13492
PS2, Line 13492: static int actual_load_config(int reload, struct ast_config *cfg, struct ast_config *ucfg)
I think you need to do a mark and sweep on the poll list instead of recreating the poll list from scratch.

Whenever you reload voicemail you cause find_or_create()->append_poll_list()->poll_mailbox() to send out notifications for each mailbox that has messages even if the counts didn't change.


https://gerrit.asterisk.org/#/c/10132/2/apps/app_voicemail.c@14098
PS2, Line 14098: 		if ((val = ast_variable_retrieve(cfg, "general", "tps_queue_high"))) {
               : 			ast_log(LOG_NOTICE, "Parameter tps_queue_high is obsolete and will be ignored\n");
               : 		}
               : 		if ((val = ast_variable_retrieve(cfg, "general", "tps_queue_low"))) {
               : 			ast_log(LOG_NOTICE, "Parameter tps_queue_low is obsolete and will be ignored\n");
Should update configs/samples/voicemail.conf.sample about these obsolete settings.



-- 
To view, visit https://gerrit.asterisk.org/10132
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cceb737246949f9782955c64425b8bd25a9e9ee
Gerrit-Change-Number: 10132
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 13 Sep 2018 23:00:31 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180913/05d37e89/attachment.html>