<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/10132">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10132/2/apps/app_voicemail.c">File apps/app_voicemail.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10132/2/apps/app_voicemail.c@13492">Patch Set #2, Line 13492:</a> <code style="font-family:monospace,monospace">static int actual_load_config(int reload, struct ast_config *cfg, struct ast_config *ucfg)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think you need to do a mark and sweep on the poll list instead of recreating the poll list from scratch.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Whenever you reload voicemail you cause find_or_create()->append_poll_list()->poll_mailbox() to send out notifications for each mailbox that has messages even if the counts didn't change.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10132/2/apps/app_voicemail.c@14098">Patch Set #2, Line 14098:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">             if ((val = ast_variable_retrieve(cfg, "general", "tps_queue_high"))) {<br>                    ast_log(LOG_NOTICE, "Parameter tps_queue_high is obsolete and will be ignored\n");<br>          }<br>             if ((val = ast_variable_retrieve(cfg, "general", "tps_queue_low"))) {<br>                     ast_log(LOG_NOTICE, "Parameter tps_queue_low is obsolete and will be ignored\n");<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should update configs/samples/voicemail.conf.sample about these obsolete settings.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10132">change 10132</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10132"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I5cceb737246949f9782955c64425b8bd25a9e9ee </div>
<div style="display:none"> Gerrit-Change-Number: 10132 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 13 Sep 2018 23:00:31 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>