[Asterisk-code-review] loader: Add support for disabled modules. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10377 )

Change subject: loader: Add support for disabled modules.
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.asterisk.org/#/c/10377/2//COMMIT_MSG
Commit Message:

https://gerrit.asterisk.org/#/c/10377/2//COMMIT_MSG@7
PS2, Line 7: loader: Add support for disabled modules.
> Can we beef up the commit message to provide some background on exactly what this is?
Based on Richards comments I'm dropping the DISABLED functionality.  Maybe worth considering in the future but I just don't have time to deal with a mass change (or much of anything) right now.  The commit msg is being expanded now that I'm confident the new patch is ready for merge.


https://gerrit.asterisk.org/#/c/10377/2/include/asterisk/module.h
File include/asterisk/module.h:

https://gerrit.asterisk.org/#/c/10377/2/include/asterisk/module.h@91
PS2, Line 91: 	/*!
            : 	 * \brief Module load is successful but disabled.
            : 	 *
            : 	 * Returning this value has the same effect as calling
            : 	 * ast_module_set_disabled(1) then returning AST_MODULE_LOAD_SUCCESS.
            : 	 * It is important that a module not unload if returning LOAD_DISABLED.
            : 	 * load_module will not be called again.  It is expected that a disabled
            : 	 * module can be enabled by modifying and reload the module's configuration.
            : 	 *
            : 	 * See \ref ast_module_set_disabled
            : 	 */
            : 	AST_MODULE_LOAD_DISABLED = 4,
> What is the benefit of returning this at all? […]
Adding a 'missingdeps' flag and using that for reporting and chained module loads seems like a good idea.  For now I won't have time to work on this further, hopefully I can get that implemented for 16.1.0.



-- 
To view, visit https://gerrit.asterisk.org/10377
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic44810ca6ce3deca30bceeb4eaa306d94f6b90e8
Gerrit-Change-Number: 10377
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Thu, 04 Oct 2018 23:43:25 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181004/4cb076c8/attachment.html>