<p><a href="https://gerrit.asterisk.org/10377">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10377/2//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10377/2//COMMIT_MSG@7">Patch Set #2, Line 7:</a> <code style="font-family:monospace,monospace">loader: Add support for disabled modules.</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Can we beef up the commit message to provide some background on exactly what this is?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Based on Richards comments I'm dropping the DISABLED functionality. Maybe worth considering in the future but I just don't have time to deal with a mass change (or much of anything) right now. The commit msg is being expanded now that I'm confident the new patch is ready for merge.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10377/2/include/asterisk/module.h">File include/asterisk/module.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10377/2/include/asterisk/module.h@91">Patch Set #2, Line 91:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> /*!<br> * \brief Module load is successful but disabled.<br> *<br> * Returning this value has the same effect as calling<br> * ast_module_set_disabled(1) then returning AST_MODULE_LOAD_SUCCESS.<br> * It is important that a module not unload if returning LOAD_DISABLED.<br> * load_module will not be called again. It is expected that a disabled<br> * module can be enabled by modifying and reload the module's configuration.<br> *<br> * See \ref ast_module_set_disabled<br> */<br> AST_MODULE_LOAD_DISABLED = 4,<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">What is the benefit of returning this at all? […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Adding a 'missingdeps' flag and using that for reporting and chained module loads seems like a good idea. For now I won't have time to work on this further, hopefully I can get that implemented for 16.1.0.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10377">change 10377</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10377"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ic44810ca6ce3deca30bceeb4eaa306d94f6b90e8 </div>
<div style="display:none"> Gerrit-Change-Number: 10377 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 04 Oct 2018 23:43:25 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>