[Asterisk-code-review] testsuite: add tests to validate the behavior of the flag us... (testsuite[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10394 )

Change subject: testsuite: add tests to validate the behavior of the flag use_callerid_contact
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/10394/2/tests/channels/pjsip/use_callerid_contact/no_privacy/contact_user/sipp/B_PARTY.xml
File tests/channels/pjsip/use_callerid_contact/no_privacy/contact_user/sipp/B_PARTY.xml:

https://gerrit.asterisk.org/#/c/10394/2/tests/channels/pjsip/use_callerid_contact/no_privacy/contact_user/sipp/B_PARTY.xml@1
PS2, Line 1: <?xml version="1.0" encoding="ISO-8859-1" ?>
This file is using CR/LF and not LF.  It would be best if you fixed the file's EOL in your master B_PARTY.xml too.

It looks like all of the B_PARTY.xml files in this patch have the incorrect line terminators.

Applying patches to these files is problematic.



-- 
To view, visit https://gerrit.asterisk.org/10394
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I168603c8397557316863116edfd0d611e7ed7ef9
Gerrit-Change-Number: 10394
Gerrit-PatchSet: 2
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 03 Oct 2018 15:27:09 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181003/a643f0bc/attachment-0001.html>