<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/10394">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10394/2/tests/channels/pjsip/use_callerid_contact/no_privacy/contact_user/sipp/B_PARTY.xml">File tests/channels/pjsip/use_callerid_contact/no_privacy/contact_user/sipp/B_PARTY.xml:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10394/2/tests/channels/pjsip/use_callerid_contact/no_privacy/contact_user/sipp/B_PARTY.xml@1">Patch Set #2, Line 1:</a> <code style="font-family:monospace,monospace"><?xml version="1.0" encoding="ISO-8859-1" ?>
</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This file is using CR/LF and not LF.  It would be best if you fixed the file's EOL in your master B_PARTY.xml too.</p><p style="white-space: pre-wrap; word-wrap: break-word;">It looks like all of the B_PARTY.xml files in this patch have the incorrect line terminators.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Applying patches to these files is problematic.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10394">change 10394</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10394"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I168603c8397557316863116edfd0d611e7ed7ef9 </div>
<div style="display:none"> Gerrit-Change-Number: 10394 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Torrey Searle <tsearle@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 03 Oct 2018 15:27:09 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: Yes </div>