[Asterisk-code-review] res pjsip: Send a 503 response when overload state if reliab... (asterisk[16])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10595 )

Change subject: res_pjsip: Send a 503 response when overload state if reliable transport.
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.asterisk.org/#/c/10595/1/res/res_pjsip/pjsip_distributor.c
File res/res_pjsip/pjsip_distributor.c:

https://gerrit.asterisk.org/#/c/10595/1/res/res_pjsip/pjsip_distributor.c@544
PS1, Line 544: If transport!=UDP then we send a 503 response
Append "instead." to the end of the sentence.

If transport!=UDP then we send a 503 response instead.


https://gerrit.asterisk.org/#/c/10595/1/res/res_pjsip/pjsip_distributor.c@546
PS1, Line 546: 			switch (rdata->tp_info.transport->key.type) {
guidelines: The switch case/default are not indented beyond the switch.  Like below:

switch () {
case x:
    break;
default:
    break;
}


https://gerrit.asterisk.org/#/c/10595/1/res/res_pjsip/pjsip_distributor.c@552
PS1, Line 552: 					ast_debug(3, "Taskprocessor overload on transpor is non-udp, sending 503");
* s/transpor/transport/
* Add pjsip_rx_data_get_info(rdata) string to the debug message to indicate which request was rejected just like the UDP debug message.



-- 
To view, visit https://gerrit.asterisk.org/10595
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c230b40d43a254ea0f226b7acf9ee480a5d3836
Gerrit-Change-Number: 10595
Gerrit-PatchSet: 1
Gerrit-Owner: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Jenkins2 (1000185)
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 06 Nov 2018 23:08:54 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20181106/b06c1c08/attachment.html>