<p><a href="https://gerrit.asterisk.org/10595">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10595/1/res/res_pjsip/pjsip_distributor.c">File res/res_pjsip/pjsip_distributor.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10595/1/res/res_pjsip/pjsip_distributor.c@544">Patch Set #1, Line 544:</a> <code style="font-family:monospace,monospace">If transport!=UDP then we send a 503 response</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Append "instead." to the end of the sentence.</p><p style="white-space: pre-wrap; word-wrap: break-word;">If transport!=UDP then we send a 503 response instead.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10595/1/res/res_pjsip/pjsip_distributor.c@546">Patch Set #1, Line 546:</a> <code style="font-family:monospace,monospace"> switch (rdata->tp_info.transport->key.type) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">guidelines: The switch case/default are not indented beyond the switch. Like below:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">switch () {<br>case x:<br> break;<br>default:<br> break;<br>}</pre></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10595/1/res/res_pjsip/pjsip_distributor.c@552">Patch Set #1, Line 552:</a> <code style="font-family:monospace,monospace"> ast_debug(3, "Taskprocessor overload on transpor is non-udp, sending 503");</code></p><ul><li>s/transpor/transport/</li><li>Add pjsip_rx_data_get_info(rdata) string to the debug message to indicate which request was rejected just like the UDP debug message.</li></ul></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10595">change 10595</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10595"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I1c230b40d43a254ea0f226b7acf9ee480a5d3836 </div>
<div style="display:none"> Gerrit-Change-Number: 10595 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Chris Savinovich <csavinovich@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 06 Nov 2018 23:08:54 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>