[Asterisk-code-review] chan dahdi: Configurable dialed digit timeouts (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8637 )

Change subject: chan_dahdi: Configurable dialed digit timeouts
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/8637/3/channels/chan_dahdi.h
File channels/chan_dahdi.h:

https://gerrit.asterisk.org/#/c/8637/3/channels/chan_dahdi.h@624
PS3, Line 624: 	int firstdigit_timeout;
> These should probably be unsigned instead.
These three timeout values get passed as a timeout value to a poll where a negative value disables the timeout.  So they should stay as ints.  However, we do need to read from the config file as an int instead of an unsigned.



-- 
To view, visit https://gerrit.asterisk.org/8637
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib728fa900a4f6ae56d1ed810aba61b6593fb7213
Gerrit-Change-Number: 8637
Gerrit-PatchSet: 3
Gerrit-Owner: Tzafrir Cohen <tzafrir.cohen at xorcom.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Oron Peled <oron.peled at xorcom.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 03 May 2018 15:23:47 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180503/09a36898/attachment.html>