<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8637">View Change</a></p><p>Patch set 3:</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8637/3/channels/chan_dahdi.h">File channels/chan_dahdi.h:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8637/3/channels/chan_dahdi.h@624">Patch Set #3, Line 624:</a> <code style="font-family:monospace,monospace">        int firstdigit_timeout;</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">These should probably be unsigned instead.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">These three timeout values get passed as a timeout value to a poll where a negative value disables the timeout.  So they should stay as ints.  However, we do need to read from the config file as an int instead of an unsigned.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8637">change 8637</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8637"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ib728fa900a4f6ae56d1ed810aba61b6593fb7213 </div>
<div style="display:none"> Gerrit-Change-Number: 8637 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Tzafrir Cohen <tzafrir.cohen@xorcom.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Matthew Fredrickson <creslin@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Oron Peled <oron.peled@xorcom.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 03 May 2018 15:23:47 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>