[Asterisk-code-review] sipp, test suite utils: Default media port to an unused port (testsuite[13])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/8689 )

Change subject: sipp, test_suite_utils: Default media port to an unused port
......................................................................


Patch Set 3:

(3 comments)

https://gerrit.asterisk.org/#/c/8689/3/lib/python/asterisk/test_suite_utils.py
File lib/python/asterisk/test_suite_utils.py:

https://gerrit.asterisk.org/#/c/8689/3/lib/python/asterisk/test_suite_utils.py@236
PS3, Line 236:                       socket.SOCK_STREAM)
TCP here as well.


https://gerrit.asterisk.org/#/c/8689/3/lib/python/asterisk/test_suite_utils.py@238
PS3, Line 238:         s.bind(('0.0.0.0', port))
Nit: Why addr='0.0.0.0' here but '' in the other function?  Also would 0.0.0.0 work for socket.AF_INET6?


https://gerrit.asterisk.org/#/c/8689/3/lib/python/asterisk/test_suite_utils.py@273
PS3, Line 273:                           socket.SOCK_STREAM)
socket.SOCK_STREAM == tcp, don't we need socket.SOCK_DGRAM for udp sockets (RTP ports)?



-- 
To view, visit https://gerrit.asterisk.org/8689
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I3da461123afc30e1f5ca12e65d289eaa42d6de00
Gerrit-Change-Number: 8689
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Fri, 30 Mar 2018 11:19:31 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180330/5ffc07d7/attachment.html>