<p>Corey Farrell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8689">View Change</a></p><p>Patch set 3:</p><p>(3 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8689/3/lib/python/asterisk/test_suite_utils.py">File lib/python/asterisk/test_suite_utils.py:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8689/3/lib/python/asterisk/test_suite_utils.py@236">Patch Set #3, Line 236:</a> <code style="font-family:monospace,monospace">                      socket.SOCK_STREAM)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">TCP here as well.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8689/3/lib/python/asterisk/test_suite_utils.py@238">Patch Set #3, Line 238:</a> <code style="font-family:monospace,monospace">        s.bind(('0.0.0.0', port))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Nit: Why addr='0.0.0.0' here but '' in the other function?  Also would 0.0.0.0 work for socket.AF_INET6?</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8689/3/lib/python/asterisk/test_suite_utils.py@273">Patch Set #3, Line 273:</a> <code style="font-family:monospace,monospace">                          socket.SOCK_STREAM)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">socket.SOCK_STREAM == tcp, don't we need socket.SOCK_DGRAM for udp sockets (RTP ports)?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8689">change 8689</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8689"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I3da461123afc30e1f5ca12e65d289eaa42d6de00 </div>
<div style="display:none"> Gerrit-Change-Number: 8689 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 30 Mar 2018 11:19:31 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>