[Asterisk-code-review] voicemail: Fixed wrong voicemail message count (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8442 )

Change subject: voicemail: Fixed wrong voicemail message count
......................................................................


Patch Set 1: Code-Review-1

(7 comments)

Versions of the patch need to be put in v13 and v15.

https://gerrit.asterisk.org/#/c/8442/1/apps/app_voicemail.c
File apps/app_voicemail.c:

https://gerrit.asterisk.org/#/c/8442/1/apps/app_voicemail.c@6093
PS1, Line 6093:  * \brief Check the given mailbox's message count.\n
The \n on the end of the line is not needed in a comment.


https://gerrit.asterisk.org/#/c/8442/1/apps/app_voicemail.c@6094
PS1, Line 6094:  * \param mailbox The \@ delimited string for user\@context. If no context is found, uses 'default' for the context.
The '@' does not need to be escaped in a comment.
If anything, you could put single quotes around the first '@' in this line.


https://gerrit.asterisk.org/#/c/8442/1/apps/app_voicemail.c@6130
PS1, Line 6130: 				}
              : 				else {
} else {


https://gerrit.asterisk.org/#/c/8442/1/apps/app_voicemail.c@6151
PS1, Line 6151: 	}
              : 	else {
} else {


https://gerrit.asterisk.org/#/c/8442/1/apps/app_voicemail.c@13286
PS1, Line 13286: 	ast_asprintf(&mailbox, "%s@%s", vmu->mailbox, vmu->context);
ast_asprintf() can fail to allocate memory for the mailbox string.  You need to check to see if it failed.


https://gerrit.asterisk.org/#/c/8442/1/apps/app_voicemail.c@13289
PS1, Line 13289: 	if(ret == -1) {
Spacing.

if (test) {
}


https://gerrit.asterisk.org/#/c/8442/1/apps/app_voicemail.c@13290
PS1, Line 13290: 		ast_log(LOG_ERROR, "Could not get mailbox count. user[%s], context[%s]", vmu->mailbox? : "", vmu->context? : "");
Spacing

vmu->mailbox ?: "", vmu->context ?: ""



-- 
To view, visit https://gerrit.asterisk.org/8442
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6578ad80bba2bfaf34b84f0be978f59045ce6cd
Gerrit-Change-Number: 8442
Gerrit-PatchSet: 1
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Tue, 06 Mar 2018 17:37:59 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180306/e9db8d1a/attachment.html>