<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8442">View Change</a></p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p style="white-space: pre-wrap; word-wrap: break-word;">Versions of the patch need to be put in v13 and v15.</p><p>(7 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8442/1/apps/app_voicemail.c">File apps/app_voicemail.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8442/1/apps/app_voicemail.c@6093">Patch Set #1, Line 6093:</a> <code style="font-family:monospace,monospace"> * \brief Check the given mailbox's message count.\n</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">The \n on the end of the line is not needed in a comment.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8442/1/apps/app_voicemail.c@6094">Patch Set #1, Line 6094:</a> <code style="font-family:monospace,monospace"> * \param mailbox The \@ delimited string for user\@context. If no context is found, uses 'default' for the context.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">The '@' does not need to be escaped in a comment.<br>If anything, you could put single quotes around the first '@' in this line.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8442/1/apps/app_voicemail.c@6130">Patch Set #1, Line 6130:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">                          }<br>                             else {<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">} else {</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8442/1/apps/app_voicemail.c@6151">Patch Set #1, Line 6151:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">       }<br>     else {<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">} else {</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8442/1/apps/app_voicemail.c@13286">Patch Set #1, Line 13286:</a> <code style="font-family:monospace,monospace">  ast_asprintf(&mailbox, "%s@%s", vmu->mailbox, vmu->context);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">ast_asprintf() can fail to allocate memory for the mailbox string.  You need to check to see if it failed.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8442/1/apps/app_voicemail.c@13289">Patch Set #1, Line 13289:</a> <code style="font-family:monospace,monospace">  if(ret == -1) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Spacing.</p><p style="white-space: pre-wrap; word-wrap: break-word;">if (test) {<br>}</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8442/1/apps/app_voicemail.c@13290">Patch Set #1, Line 13290:</a> <code style="font-family:monospace,monospace">            ast_log(LOG_ERROR, "Could not get mailbox count. user[%s], context[%s]", vmu->mailbox? : "", vmu->context? : "");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Spacing</p><p style="white-space: pre-wrap; word-wrap: break-word;">vmu->mailbox ?: "", vmu->context ?: ""</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8442">change 8442</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8442"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ie6578ad80bba2bfaf34b84f0be978f59045ce6cd </div>
<div style="display:none"> Gerrit-Change-Number: 8442 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: sungtae kim <pchero21@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: sungtae kim <pchero21@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 06 Mar 2018 17:37:59 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>