[Asterisk-code-review] res pjsip session: Add ability to accept multiple sdp answers (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/9200 )

Change subject: res_pjsip_session:  Add ability to accept multiple sdp answers
......................................................................


Patch Set 6: Code-Review-1

(13 comments)

https://gerrit.asterisk.org/#/c/9200/6/CHANGES
File CHANGES:

https://gerrit.asterisk.org/#/c/9200/6/CHANGES@48
PS6, Line 48: that
s/that/than


https://gerrit.asterisk.org/#/c/9200/6/CHANGES@55
PS6, Line 55:     "no" which is the current behavior. 
Space at end of the line.


https://gerrit.asterisk.org/#/c/9200/6/CHANGES@56
PS6, Line 56:     
whitespace


https://gerrit.asterisk.org/#/c/9200/6/configs/samples/pjsip.conf.sample
File configs/samples/pjsip.conf.sample:

https://gerrit.asterisk.org/#/c/9200/6/configs/samples/pjsip.conf.sample@795
PS6, Line 795: that
s/that/than


https://gerrit.asterisk.org/#/c/9200/6/configs/samples/pjsip.conf.sample@806
PS6, Line 806: that
remove 'that'


https://gerrit.asterisk.org/#/c/9200/6/configs/samples/pjsip.conf.sample@962
PS6, Line 962: that
s/that/than


https://gerrit.asterisk.org/#/c/9200/6/configs/samples/pjsip.conf.sample@973
PS6, Line 973: that
remote 'that'


https://gerrit.asterisk.org/#/c/9200/6/res/res_pjsip.c
File res/res_pjsip.c:

https://gerrit.asterisk.org/#/c/9200/6/res/res_pjsip.c@1035
PS6, Line 1035: that
s/that/than


https://gerrit.asterisk.org/#/c/9200/6/res/res_pjsip.c@1050
PS6, Line 1050: that
delete 'that'


https://gerrit.asterisk.org/#/c/9200/6/res/res_pjsip.c@1632
PS6, Line 1632: that
s/that/than


https://gerrit.asterisk.org/#/c/9200/6/res/res_pjsip.c@1646
PS6, Line 1646: that
delete 'that'


https://gerrit.asterisk.org/#/c/9200/6/res/res_pjsip/config_system.c
File res/res_pjsip/config_system.c:

https://gerrit.asterisk.org/#/c/9200/6/res/res_pjsip/config_system.c@58
PS6, Line 58: onm
s/onm/on


https://gerrit.asterisk.org/#/c/9200/6/res/res_pjsip_session.c
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/#/c/9200/6/res/res_pjsip_session.c@3079
PS6, Line 3079: 		if (inv->updated_sdp_answer) {
looks like following_fork and update_sdp_answer can never both be true. Should this be an 'else if...' clause?



-- 
To view, visit https://gerrit.asterisk.org/9200
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I64d071942b79adb2f0a4e13137389b19404fe3d6
Gerrit-Change-Number: 9200
Gerrit-PatchSet: 6
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 21 Jun 2018 16:36:33 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180621/36e7fab2/attachment-0001.html>