<p>Kevin Harwell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/9200">View Change</a></p><p>Patch set 6:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(13 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/9200/6/CHANGES">File CHANGES:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9200/6/CHANGES@48">Patch Set #6, Line 48:</a> <code style="font-family:monospace,monospace">that</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/that/than</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9200/6/CHANGES@55">Patch Set #6, Line 55:</a> <code style="font-family:monospace,monospace">    "no" which is the current behavior. </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Space at end of the line.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9200/6/CHANGES@56">Patch Set #6, Line 56:</a> <code style="font-family:monospace,monospace">    </code></p><p style="white-space: pre-wrap; word-wrap: break-word;">whitespace</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/9200/6/configs/samples/pjsip.conf.sample">File configs/samples/pjsip.conf.sample:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9200/6/configs/samples/pjsip.conf.sample@795">Patch Set #6, Line 795:</a> <code style="font-family:monospace,monospace">that</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/that/than</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9200/6/configs/samples/pjsip.conf.sample@806">Patch Set #6, Line 806:</a> <code style="font-family:monospace,monospace">that</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">remove 'that'</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9200/6/configs/samples/pjsip.conf.sample@962">Patch Set #6, Line 962:</a> <code style="font-family:monospace,monospace">that</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/that/than</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9200/6/configs/samples/pjsip.conf.sample@973">Patch Set #6, Line 973:</a> <code style="font-family:monospace,monospace">that</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">remote 'that'</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/9200/6/res/res_pjsip.c">File res/res_pjsip.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9200/6/res/res_pjsip.c@1035">Patch Set #6, Line 1035:</a> <code style="font-family:monospace,monospace">that</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/that/than</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9200/6/res/res_pjsip.c@1050">Patch Set #6, Line 1050:</a> <code style="font-family:monospace,monospace">that</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">delete 'that'</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9200/6/res/res_pjsip.c@1632">Patch Set #6, Line 1632:</a> <code style="font-family:monospace,monospace">that</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/that/than</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9200/6/res/res_pjsip.c@1646">Patch Set #6, Line 1646:</a> <code style="font-family:monospace,monospace">that</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">delete 'that'</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/9200/6/res/res_pjsip/config_system.c">File res/res_pjsip/config_system.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9200/6/res/res_pjsip/config_system.c@58">Patch Set #6, Line 58:</a> <code style="font-family:monospace,monospace">onm</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">s/onm/on</p></li></ul></li><li><p><a href="https://gerrit.asterisk.org/#/c/9200/6/res/res_pjsip_session.c">File res/res_pjsip_session.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/9200/6/res/res_pjsip_session.c@3079">Patch Set #6, Line 3079:</a> <code style="font-family:monospace,monospace">            if (inv->updated_sdp_answer) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">looks like following_fork and update_sdp_answer can never both be true. Should this be an 'else if...' clause?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/9200">change 9200</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/9200"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I64d071942b79adb2f0a4e13137389b19404fe3d6 </div>
<div style="display:none"> Gerrit-Change-Number: 9200 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 21 Jun 2018 16:36:33 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>