[Asterisk-code-review] utils socket: range of random ports searched only once (testsuite[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/8866 )

Change subject: utils_socket: range of random ports searched only once
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

Nit pick but putting the -1 so it's noticed.

https://gerrit.asterisk.org/#/c/8866/2/lib/python/asterisk/utils_socket.py
File lib/python/asterisk/utils_socket.py:

https://gerrit.asterisk.org/#/c/8866/2/lib/python/asterisk/utils_socket.py@246
PS2, Line 246:                 return port
We should 'return [port]' for consistency since this function is documented to return a list not an int.


https://gerrit.asterisk.org/#/c/8866/2/lib/python/asterisk/utils_socket.py@256
PS2, Line 256:             if ports:
Is this check needed or can we assume that since no exception was thrown that we have ports?  I'm indifferent to this check being here but I don't think it's possible for us to hit the false condition.



-- 
To view, visit https://gerrit.asterisk.org/8866
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I96affa9df38acf569f5d3c0965ac7b78d865455d
Gerrit-Change-Number: 8866
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Thu, 26 Apr 2018 10:49:13 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180426/a1ff8163/attachment.html>