<p>Corey Farrell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8866">View Change</a></p><p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p style="white-space: pre-wrap; word-wrap: break-word;">Nit pick but putting the -1 so it's noticed.</p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8866/2/lib/python/asterisk/utils_socket.py">File lib/python/asterisk/utils_socket.py:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8866/2/lib/python/asterisk/utils_socket.py@246">Patch Set #2, Line 246:</a> <code style="font-family:monospace,monospace">                return port</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">We should 'return [port]' for consistency since this function is documented to return a list not an int.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8866/2/lib/python/asterisk/utils_socket.py@256">Patch Set #2, Line 256:</a> <code style="font-family:monospace,monospace">            if ports:</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Is this check needed or can we assume that since no exception was thrown that we have ports?  I'm indifferent to this check being here but I don't think it's possible for us to hit the false condition.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8866">change 8866</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8866"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I96affa9df38acf569f5d3c0965ac7b78d865455d </div>
<div style="display:none"> Gerrit-Change-Number: 8866 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 26 Apr 2018 10:49:13 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>