[Asterisk-code-review] app voicemail: Fix data-type mismatch between app voicemail ... (asterisk[13])

[Matthew Fredrickson]

Matthew Fredrickson has posted comments on this change. ( https://gerrit.asterisk.org/8681 )

Change subject: app_voicemail: Fix data-type mismatch between app_voicemail and database
......................................................................


Patch Set 3: Code-Review-1

(6 comments)

Looks mostly good!  Just a few coding style nit picks to clean up.

https://gerrit.asterisk.org/#/c/8681/3/apps/app_voicemail.c
File apps/app_voicemail.c:

https://gerrit.asterisk.org/#/c/8681/3/apps/app_voicemail.c@4282
PS3, Line 4282: 	const long result = strtol(str, &endptr, 10);
Variable declaration needs to go at the top of the current scope block (which for this is at the beginning of the function)


https://gerrit.asterisk.org/#/c/8681/3/apps/app_voicemail.c@4285
PS3, Line 4285: 		// nothing parsed from the string - string is empty
Need to try to get rid of C++ style comments prior to merging.


https://gerrit.asterisk.org/#/c/8681/3/apps/app_voicemail.c@4290
PS3, Line 4290: 		// dodgy characters at end of input.
Need to try to get rid of C++ style comments prior to merging.


https://gerrit.asterisk.org/#/c/8681/3/apps/app_voicemail.c@4295
PS3, Line 4295: 		// Out of range for long - nowhere near an int.
Need to try to get rid of C++ style comments prior to merging.


https://gerrit.asterisk.org/#/c/8681/3/apps/app_voicemail.c@4300
PS3, Line 4300: 		// out of range (too high) - maybe zero is better here
Need to try to get rid of C++ style comments prior to merging.


https://gerrit.asterisk.org/#/c/8681/3/apps/app_voicemail.c@4305
PS3, Line 4305: 		// out of range (too low) - maybe zero is better here
Need to try to get rid of C++ style comments prior to merging. Need to use /* */ instead.



-- 
To view, visit https://gerrit.asterisk.org/8681
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I8543ad480a08c98be78bde1ee870e6e6c84b2c5b
Gerrit-Change-Number: 8681
Gerrit-PatchSet: 3
Gerrit-Owner: Nic Colledge <nic at njcolledge.net>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Comment-Date: Wed, 04 Apr 2018 14:07:49 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180404/138f89aa/attachment-0001.html>