<p>Matthew Fredrickson <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/8681">View Change</a></p><p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p style="white-space: pre-wrap; word-wrap: break-word;">Looks mostly good! Just a few coding style nit picks to clean up.</p><p>(6 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/8681/3/apps/app_voicemail.c">File apps/app_voicemail.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8681/3/apps/app_voicemail.c@4282">Patch Set #3, Line 4282:</a> <code style="font-family:monospace,monospace"> const long result = strtol(str, &endptr, 10);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Variable declaration needs to go at the top of the current scope block (which for this is at the beginning of the function)</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8681/3/apps/app_voicemail.c@4285">Patch Set #3, Line 4285:</a> <code style="font-family:monospace,monospace"> // nothing parsed from the string - string is empty</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Need to try to get rid of C++ style comments prior to merging.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8681/3/apps/app_voicemail.c@4290">Patch Set #3, Line 4290:</a> <code style="font-family:monospace,monospace"> // dodgy characters at end of input.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Need to try to get rid of C++ style comments prior to merging.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8681/3/apps/app_voicemail.c@4295">Patch Set #3, Line 4295:</a> <code style="font-family:monospace,monospace"> // Out of range for long - nowhere near an int.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Need to try to get rid of C++ style comments prior to merging.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8681/3/apps/app_voicemail.c@4300">Patch Set #3, Line 4300:</a> <code style="font-family:monospace,monospace"> // out of range (too high) - maybe zero is better here</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Need to try to get rid of C++ style comments prior to merging.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/8681/3/apps/app_voicemail.c@4305">Patch Set #3, Line 4305:</a> <code style="font-family:monospace,monospace"> // out of range (too low) - maybe zero is better here</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Need to try to get rid of C++ style comments prior to merging. Need to use /* */ instead.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/8681">change 8681</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/8681"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I8543ad480a08c98be78bde1ee870e6e6c84b2c5b </div>
<div style="display:none"> Gerrit-Change-Number: 8681 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Nic Colledge <nic@njcolledge.net> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Matthew Fredrickson <creslin@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 04 Apr 2018 14:07:49 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>