[Asterisk-code-review] chan sip: Do not change IP address in SDP origin line (o=) i... (asterisk[13])

[Walter Doekes]

Walter Doekes has posted comments on this change. ( https://gerrit.asterisk.org/6419 )

Change subject: chan_sip: Do not change IP address in SDP origin line (o=) in SIP reINVITE
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/6419/2/channels/chan_sip.c
File channels/chan_sip.c:

https://gerrit.asterisk.org/#/c/6419/2/channels/chan_sip.c@13518
PS2, Line 13518: 		 (ast_sockaddr_is_ipv6(&dest) && !ast_sockaddr_is_ipv4_mapped(&dest)) ?
               : 			"IP6" : "IP4",
> This should also be updated to use p->ourip and not dest.
Perhaps also a small comment about why we're not using 'dest' on the o=-line is in order.

Next time someone looks at this they might wonder why we're not using dest -- which would be right if we weren't doing c=-altering reinvites.



-- 
To view, visit https://gerrit.asterisk.org/6419
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I533a047490c43dcff32eeca8378b2ba02345b64e
Gerrit-Change-Number: 6419
Gerrit-PatchSet: 2
Gerrit-Owner: Vitezslav Novy <a1 at vnovy.net>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-Comment-Date: Wed, 06 Sep 2017 11:54:29 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170906/2586393d/attachment.html>