<p>Walter Doekes <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/6419">View Change</a></p><p>Patch set 2:</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/6419/2/channels/chan_sip.c">File channels/chan_sip.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6419/2/channels/chan_sip.c@13518">Patch Set #2, Line 13518:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">                (ast_sockaddr_is_ipv6(&dest) && !ast_sockaddr_is_ipv4_mapped(&dest)) ?<br>                       "IP6" : "IP4",<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This should also be updated to use p->ourip and not dest.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Perhaps also a small comment about why we're not using 'dest' on the o=-line is in order.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Next time someone looks at this they might wonder why we're not using dest -- which would be right if we weren't doing c=-altering reinvites.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/6419">change 6419</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6419"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I533a047490c43dcff32eeca8378b2ba02345b64e </div>
<div style="display:none"> Gerrit-Change-Number: 6419 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Vitezslav Novy <a1@vnovy.net> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Walter Doekes <walter+asterisk@wjd.nu> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 06 Sep 2017 11:54:29 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>