[Asterisk-code-review] res pjsip pubsub: Prevent unload except during shutdown. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/6833 )

Change subject: res_pjsip_pubsub: Prevent unload except during shutdown.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/6833/1/res/res_pjsip_pubsub.c
File res/res_pjsip_pubsub.c:

https://gerrit.asterisk.org/#/c/6833/1/res/res_pjsip_pubsub.c@5418
PS1, Line 5418: 	if (ast_sip_register_service(&pubsub_module)) {
I'm fairly confident it's safe to move this registration to occur after sorcery is initialized.  I'm not sure if it's actually safe to register the service before the remaining calls to pjsip_* functions.

Will cherry-pick to 13/15 once someone has a look at this.



-- 
To view, visit https://gerrit.asterisk.org/6833
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee900f20bdd6ee1bfe23efdec0d87765eadce8a7
Gerrit-Change-Number: 6833
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Comment-Date: Wed, 18 Oct 2017 18:44:57 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171018/00d381d1/attachment.html>