<p>Corey Farrell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/6833">View Change</a></p><p>Patch set 1:</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/6833/1/res/res_pjsip_pubsub.c">File res/res_pjsip_pubsub.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6833/1/res/res_pjsip_pubsub.c@5418">Patch Set #1, Line 5418:</a> <code style="font-family:monospace,monospace">     if (ast_sip_register_service(&pubsub_module)) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'm fairly confident it's safe to move this registration to occur after sorcery is initialized.  I'm not sure if it's actually safe to register the service before the remaining calls to pjsip_* functions.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Will cherry-pick to 13/15 once someone has a look at this.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/6833">change 6833</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6833"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Iee900f20bdd6ee1bfe23efdec0d87765eadce8a7 </div>
<div style="display:none"> Gerrit-Change-Number: 6833 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 18 Oct 2017 18:44:57 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>