[Asterisk-code-review] sorcery: Use ao2 weakproxy to hold list of instances. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/6712 )

Change subject: sorcery: Use ao2_weakproxy to hold list of instances.
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/6712/3/main/sorcery.c
File main/sorcery.c:

https://gerrit.asterisk.org/#/c/6712/3/main/sorcery.c@210
PS3, Line 210: /*! \internal \brief Proxy object for sorcery */
Still here.


https://gerrit.asterisk.org/#/c/6712/3/main/sorcery.c@774
PS3, Line 774: 	ao2_lock(instances);
instances has a rwlock so should use ao2_wrlock() even though ao2_lock() behaves like ao2_wrlock() for a rwlock.



-- 
To view, visit https://gerrit.asterisk.org/6712
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a150a4e13cee319d46b5a4654f95a4623a978f8
Gerrit-Change-Number: 6712
Gerrit-PatchSet: 3
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 10 Oct 2017 23:31:40 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171010/564a5c64/attachment.html>