<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/6712">View Change</a></p><p>Patch set 3:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/6712/3/main/sorcery.c">File main/sorcery.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6712/3/main/sorcery.c@210">Patch Set #3, Line 210:</a> <code style="font-family:monospace,monospace">/*! \internal \brief Proxy object for sorcery */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Still here.</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6712/3/main/sorcery.c@774">Patch Set #3, Line 774:</a> <code style="font-family:monospace,monospace">    ao2_lock(instances);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">instances has a rwlock so should use ao2_wrlock() even though ao2_lock() behaves like ao2_wrlock() for a rwlock.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/6712">change 6712</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6712"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I5a150a4e13cee319d46b5a4654f95a4623a978f8 </div>
<div style="display:none"> Gerrit-Change-Number: 6712 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 10 Oct 2017 23:31:40 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>