[Asterisk-code-review] res pjsip: Prevent "user=phone" being added multiple times t... (asterisk[13])

[dtryba]

dtryba has posted comments on this change. ( https://gerrit.asterisk.org/6671 )

Change subject: res_pjsip: Prevent "user=phone" being added multiple times to header
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/6671/1/res/res_pjsip.c
File res/res_pjsip.c:

https://gerrit.asterisk.org/#/c/6671/1/res/res_pjsip.c@3051
PS1, Line 3051: 	pjsip_uri_print(PJSIP_URI_IN_REQ_URI, sip_uri, check_uri, sizeof(check_uri));
> Instead of printing out the URI and then doing a strcasestr why didn't you 
Needed this string for logging during finding out what caused multiples.

But RFC3261 19.1.1 states:
         Even though an arbitrary number of URI parameters may be
         included in a URI, any given parameter-name MUST NOT appear
         more than once.

Shouldn't the other_param be a hash (with unique keys)?



-- 
To view, visit https://gerrit.asterisk.org/6671
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib84383b07254de357dc6a98d91fc1d2c2c3719e6
Gerrit-Change-Number: 6671
Gerrit-PatchSet: 1
Gerrit-Owner: dtryba <daniel at tryba.nl>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: dtryba <daniel at tryba.nl>
Gerrit-Comment-Date: Tue, 10 Oct 2017 11:56:25 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171010/d6646b1f/attachment.html>