<p>dtryba <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/6671">View Change</a></p><p>Patch set 1:</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/6671/1/res/res_pjsip.c">File res/res_pjsip.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6671/1/res/res_pjsip.c@3051">Patch Set #1, Line 3051:</a> <code style="font-family:monospace,monospace"> pjsip_uri_print(PJSIP_URI_IN_REQ_URI, sip_uri, check_uri, sizeof(check_uri));</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Instead of printing out the URI and then doing a strcasestr why didn't you </blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Needed this string for logging during finding out what caused multiples.</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">But RFC3261 19.1.1 states:<br>         Even though an arbitrary number of URI parameters may be<br>         included in a URI, any given parameter-name MUST NOT appear<br>         more than once.</pre><p style="white-space: pre-wrap; word-wrap: break-word;">Shouldn't the other_param be a hash (with unique keys)?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/6671">change 6671</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6671"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ib84383b07254de357dc6a98d91fc1d2c2c3719e6 </div>
<div style="display:none"> Gerrit-Change-Number: 6671 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dtryba <daniel@tryba.nl> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: dtryba <daniel@tryba.nl> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 10 Oct 2017 11:56:25 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>