[Asterisk-code-review] chan pjsip: Multistream: Configure stream maxima (asterisk[master])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/5841 )

Change subject: chan_pjsip: Multistream: Configure stream maxima
......................................................................


Patch Set 7: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/5841/7/res/res_pjsip_session.c
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/#/c/5841/7/res/res_pjsip_session.c@268
PS7, Line 268: limitation_reached
Nitpick: The naming of this function doesn't describe the limitation that was reached. Maybe media_limit_reached instead?


https://gerrit.asterisk.org/#/c/5841/7/res/res_pjsip_session.c@272
PS7, Line 272: 		if (type_streams[type] < endpoint->media.max_audio_streams) {
             : 			return 0;
             : 		} else {
             : 			return 1;
             : 		}
             : 	case AST_MEDIA_TYPE_VIDEO:
             : 		if (type_streams[type] < endpoint->media.max_video_streams) {
             : 			return 0;
             : 		} else {
             : 			return 1;
             : 		}
             : 	case AST_MEDIA_TYPE_IMAGE:
             : 	case AST_MEDIA_TYPE_TEXT:
             : 		/* We don't have an option for image (T.38) and text streams
             : 		 * so we cap these at one
             : 		 */
             : 		if (type_streams[type] > 0) {
             : 			return 1;
             : 		} else {
             : 			return 0;
             : 		}
Just return the result of the comparison (or negation if necessary)



-- 
To view, visit https://gerrit.asterisk.org/5841
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4b192c06fb311428d907ece78a131fdebc29163
Gerrit-Change-Number: 5841
Gerrit-PatchSet: 7
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 20 Jun 2017 17:18:50 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170620/428be2d0/attachment.html>