<p>Sean Bright <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/5841">View Change</a></p><p>Patch set 7:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p>(2 comments)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/5841/7/res/res_pjsip_session.c">File res/res_pjsip_session.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5841/7/res/res_pjsip_session.c@268">Patch Set #7, Line 268:</a> <code style="font-family:monospace,monospace">limitation_reached</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Nitpick: The naming of this function doesn't describe the limitation that was reached. Maybe media_limit_reached instead?</p></li><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5841/7/res/res_pjsip_session.c@272">Patch Set #7, Line 272:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">           if (type_streams[type] < endpoint->media.max_audio_streams) {<br>                   return 0;<br>             } else {<br>                      return 1;<br>             }<br>     case AST_MEDIA_TYPE_VIDEO:<br>            if (type_streams[type] < endpoint->media.max_video_streams) {<br>                   return 0;<br>             } else {<br>                      return 1;<br>             }<br>     case AST_MEDIA_TYPE_IMAGE:<br>    case AST_MEDIA_TYPE_TEXT:<br>             /* We don't have an option for image (T.38) and text streams<br>               * so we cap these at one<br>              */<br>           if (type_streams[type] > 0) {<br>                      return 1;<br>             } else {<br>                      return 0;<br>             }<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Just return the result of the comparison (or negation if necessary)</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/5841">change 5841</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/5841"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Id4b192c06fb311428d907ece78a131fdebc29163 </div>
<div style="display:none"> Gerrit-Change-Number: 5841 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: Mark Michelson <mmichelson@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 20 Jun 2017 17:18:50 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>