[Asterisk-code-review] SDP: Rework SDP offer/answer model and update capabilities m... (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/5819 )

Change subject: SDP: Rework SDP offer/answer model and update capabilities merges.
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.asterisk.org/#/c/5819/4/main/sdp_state.c
File main/sdp_state.c:

https://gerrit.asterisk.org/#/c/5819/4/main/sdp_state.c@536
PS4, Line 536: 	if (cb) {
> No, more of a "why didn't you just return early and reduce indentation"
In this case returning early wouldn't help reduce the indentation level.  The AST_DEVMODE additional variable declarations have run time array dimensioning that would be wasted if there isn't a callback.

The other four callback invoking routines could but there really isn't a need to reduce their indentation either.



-- 
To view, visit https://gerrit.asterisk.org/5819
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If07fe6d79fbdce33968a9401d41d908385043a06
Gerrit-Change-Number: 5819
Gerrit-PatchSet: 4
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 16 Jun 2017 16:43:07 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170616/4db9d196/attachment.html>