<p>Richard Mudgett <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/5819">View Change</a></p><p>Patch set 4:</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/5819/4/main/sdp_state.c">File main/sdp_state.c:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/5819/4/main/sdp_state.c@536">Patch Set #4, Line 536:</a> <code style="font-family:monospace,monospace">       if (cb) {</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">No, more of a "why didn't you just return early and reduce indentation"</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">In this case returning early wouldn't help reduce the indentation level.  The AST_DEVMODE additional variable declarations have run time array dimensioning that would be wasted if there isn't a callback.</p><p style="white-space: pre-wrap; word-wrap: break-word;">The other four callback invoking routines could but there really isn't a need to reduce their indentation either.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/5819">change 5819</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/5819"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: If07fe6d79fbdce33968a9401d41d908385043a06 </div>
<div style="display:none"> Gerrit-Change-Number: 5819 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 16 Jun 2017 16:43:07 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>