[Asterisk-code-review] PJPROJECT logging: Fix detection of max supported log level. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/4767 )

Change subject: PJPROJECT logging: Fix detection of max supported log level.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/4767/1/include/asterisk/options.h
File include/asterisk/options.h:

Line 147:  * Determine the maximum log level the pjproject we linked with supports.
> Minor not but isn't it the max level of the pjproject we're running against
Whether we are statically linked or dynamically linked we are still linked with a pjproject.  It is just a matter of when we got linked with it.  We are getting the max level of the pjproject we got linked with.  This is not going to get the define value set when we were compiled.

I say potaato you say potauto...


-- 
To view, visit https://gerrit.asterisk.org/4767
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I40aa76653e2a1dece66c3f8734594b4f0471cfb4
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes