[Asterisk-code-review] PJPROJECT logging: Fix detection of max supported log level. (asterisk[13])

George Joseph asteriskteam at digium.com
Mon Jan 23 15:21:55 CST 2017


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/4767 )

Change subject: PJPROJECT logging: Fix detection of max supported log level.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/4767/1/include/asterisk/options.h
File include/asterisk/options.h:

Line 147:  * Determine the maximum log level the pjproject we linked with supports.
Minor not but isn't it the max level of the pjproject we're running against as opposed to linked with?  If not using the bundled version, asterisk could have been linked against pjproject configured 1 way but running against pjproject configured a different way.


-- 
To view, visit https://gerrit.asterisk.org/4767
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I40aa76653e2a1dece66c3f8734594b4f0471cfb4
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list