[Asterisk-code-review] astobj2: Header macro's should deal with error's from ao2 ref. (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: astobj2: Header macro's should deal with error's from ao2_ref.
......................................................................


Patch Set 2:

> (1 comment)
 > 
 > I'm not sure how beneficial this patch is.  Passing bogus ao2
 > objects to these macros/functions is already a programming error
 > that is caught by assertions if they are enabled.

The idea is that when we've identified a bogus ao2, we should stop passing it around - limit the damage.  An example is in __ao2_alloc I used ao2_t_bump(lockobj, "set lockobj").  The intent was that if lockobj is invalid this would return NULL and abort allocation of the new AO2 object.

In any case if you feel this is wasteful / over-aggressive error checking I can abandon.

-- 
To view, visit https://gerrit.asterisk.org/3872
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e06d27fb6667f54c960023aa3b93d95b07147de
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No