[Asterisk-code-review] astobj2: Header macro's should deal with error's from ao2 ref. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: astobj2: Header macro's should deal with error's from ao2_ref.
......................................................................


Patch Set 2:

(1 comment)

I'm not sure how beneficial this patch is.  Passing bogus ao2 objects to these macros/functions is already a programming error that is caught by assertions if they are enabled.

https://gerrit.asterisk.org/#/c/3872/2/include/asterisk/astobj2.h
File include/asterisk/astobj2.h:

Line 570: 					__had_error_ ## __LINE__ = 1; \
> This would cause a compile error depending on the typeof(src).  For example
ao2_t_ref() cannot take a const ao2 object so you cannot pass a const object pointer.

However if src were declared: 
struct ast_codec * const src
then you would have the error without ao2_t_ref() complaining about a const qualifier being removed.

I see your point now.


-- 
To view, visit https://gerrit.asterisk.org/3872
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e06d27fb6667f54c960023aa3b93d95b07147de
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes