[Asterisk-code-review] tcptls: Use new certificate upon sip reload (asterisk[13])

[Michael Kuron]

Michael Kuron has posted comments on this change. ( https://gerrit.asterisk.org/4448 )

Change subject: tcptls: Use new certificate upon sip reload
......................................................................


Patch Set 2:

Yes, that race condition is probably there. However, looking at chan_sip’s reload_config, it does not seem to me that sip reload is an atomic operation. All peers are deleted at the beginning and recreated at the end. At one point between these two operations, the TLS socket is briefly closed and re-opened due to my change. So while new connections would briefly be rejected during the reload, chan_sip is not able to serve those requests at that time anyway. If my interpretation is correct, this means I'm not adding a race condition that's not already present.

-- 
To view, visit https://gerrit.asterisk.org/4448
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I169e86cefc6dcd627c915134015a6a1ab1aadbe6
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Michael Kuron <m.kuron at gmx.de>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Michael Kuron <m.kuron at gmx.de>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: No